Re: [PR] refactor: add factory functions for primitive types [iceberg-cpp]

2025-07-07 Thread via GitHub
Xuanwo merged PR #134: URL: https://github.com/apache/iceberg-cpp/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] refactor: add factory functions for primitive types [iceberg-cpp]

2025-07-01 Thread via GitHub
zhjwpku commented on PR #134: URL: https://github.com/apache/iceberg-cpp/pull/134#issuecomment-3024221304 The cpp-linter is failing because the Thrift download step failed. I'd appreciate it if you could help trigger a rerun of the action and also take a moment to review the changes. @Fokko

Re: [PR] refactor: add factory functions for primitive types [iceberg-cpp]

2025-07-01 Thread via GitHub
zhjwpku commented on code in PR #134: URL: https://github.com/apache/iceberg-cpp/pull/134#discussion_r2177012992 ## src/iceberg/type.h: ## @@ -446,4 +446,48 @@ class ICEBERG_EXPORT UuidType : public PrimitiveType { /// @} +/// \defgroup type-factories Factory functions for

Re: [PR] refactor: add factory functions for primitive types [iceberg-cpp]

2025-06-30 Thread via GitHub
mapleFU commented on code in PR #134: URL: https://github.com/apache/iceberg-cpp/pull/134#discussion_r2175398602 ## src/iceberg/type.h: ## @@ -446,4 +446,48 @@ class ICEBERG_EXPORT UuidType : public PrimitiveType { /// @} +/// \defgroup type-factories Factory functions for

Re: [PR] refactor: add factory functions for primitive types [iceberg-cpp]

2025-06-30 Thread via GitHub
zhjwpku commented on PR #134: URL: https://github.com/apache/iceberg-cpp/pull/134#issuecomment-3019520789 Before I touch more code, I'd like to hear your thoughts on these factory functions for primitive types. For decimal and fixed types, return a newly created shared_ptr, while for other

[PR] refactor: add factory functions for primitive types [iceberg-cpp]

2025-06-30 Thread via GitHub
zhjwpku opened a new pull request, #134: URL: https://github.com/apache/iceberg-cpp/pull/134 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-