Re: [PR] refactor(manifests): consolidate ManifestEntryV1 and V2 [iceberg-go]

2025-03-11 Thread via GitHub
zeroshade merged PR #327: URL: https://github.com/apache/iceberg-go/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] refactor(manifests): consolidate ManifestEntryV1 and V2 [iceberg-go]

2025-03-11 Thread via GitHub
kevinjqliu commented on code in PR #327: URL: https://github.com/apache/iceberg-go/pull/327#discussion_r1989735973 ## manifest.go: ## @@ -1477,131 +1470,68 @@ func (d *dataFile) EqualityFieldIDs() []int { func (d *dataFile) SortOrderID() *int { return d.SortOrder } -// Mani

Re: [PR] refactor(manifests): consolidate ManifestEntryV1 and V2 [iceberg-go]

2025-03-11 Thread via GitHub
zeroshade commented on code in PR #327: URL: https://github.com/apache/iceberg-go/pull/327#discussion_r1989727738 ## manifest.go: ## @@ -1477,131 +1470,68 @@ func (d *dataFile) EqualityFieldIDs() []int { func (d *dataFile) SortOrderID() *int { return d.SortOrder } -// Manif

Re: [PR] refactor(manifests): consolidate ManifestEntryV1 and V2 [iceberg-go]

2025-03-11 Thread via GitHub
kevinjqliu commented on code in PR #327: URL: https://github.com/apache/iceberg-go/pull/327#discussion_r1989698267 ## manifest.go: ## @@ -501,13 +501,11 @@ func fetchManifestEntries(m ManifestFile, fs iceio.IO, discardDeleted bool) ([]M } fieldNameToID, fieldI