Re: [PR] refactor(iceberg): Remove an extra config parse logic [iceberg-rust]

liurenjie1024 merged PR #499: URL: https://github.com/apache/iceberg-rust/pull/499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] refactor(iceberg): Remove an extra config parse logic [iceberg-rust]

Xuanwo commented on code in PR #499: URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695300548 ## crates/iceberg/src/io/storage_memory.rs: ## @@ -15,31 +15,11 @@ // specific language governing permissions and limitations // under the License. -use std::coll

Re: [PR] refactor(iceberg): Remove an extra config parse logic [iceberg-rust]

Xuanwo commented on code in PR #499: URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695280401 ## Cargo.toml: ## @@ -67,7 +67,7 @@ log = "^0.4" mockito = "^1" murmur3 = "0.5.2" once_cell = "1" -opendal = "0.47" +opendal = "0.48" Review Comment: Hi, @liur

Re: [PR] refactor(iceberg): Remove an extra config parse logic [iceberg-rust]

Xuanwo commented on code in PR #499: URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695277156 ## Cargo.toml: ## @@ -67,7 +67,7 @@ log = "^0.4" mockito = "^1" murmur3 = "0.5.2" once_cell = "1" -opendal = "0.47" +opendal = "0.48" Review Comment: This PR r

Re: [PR] refactor(iceberg): Remove an extra config parse logic [iceberg-rust]

Xuanwo commented on code in PR #499: URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695276546 ## Cargo.toml: ## @@ -67,7 +67,7 @@ log = "^0.4" mockito = "^1" murmur3 = "0.5.2" once_cell = "1" -opendal = "0.47" +opendal = "0.48" Review Comment: Got, let

Re: [PR] refactor(iceberg): Remove an extra config parse logic [iceberg-rust]

Fokko commented on code in PR #499: URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695272318 ## Cargo.toml: ## @@ -67,7 +67,7 @@ log = "^0.4" mockito = "^1" murmur3 = "0.5.2" once_cell = "1" -opendal = "0.47" +opendal = "0.48" Review Comment: Nit: I thi

Re: [PR] refactor(iceberg): Remove an extra config parse logic [iceberg-rust]

liurenjie1024 commented on code in PR #499: URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695271890 ## crates/iceberg/src/io/storage_memory.rs: ## @@ -15,31 +15,11 @@ // specific language governing permissions and limitations // under the License. -use st

[PR] refactor(iceberg): Remove an extra config parse logic [iceberg-rust]

Xuanwo opened a new pull request, #499: URL: https://github.com/apache/iceberg-rust/pull/499 This PR will remove an extra config parse logic that maps iceberg props into config directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on