Re: [PR] reduce enum array allocation [iceberg]

2024-04-12 Thread via GitHub
nastra merged PR #10126: URL: https://github.com/apache/iceberg/pull/10126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] reduce enum array allocation [iceberg]

2024-04-12 Thread via GitHub
sullis commented on PR #10126: URL: https://github.com/apache/iceberg/pull/10126#issuecomment-2051999782 CI build looks good ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] reduce enum array allocation [iceberg]

2024-04-12 Thread via GitHub
sullis commented on PR #10126: URL: https://github.com/apache/iceberg/pull/10126#issuecomment-2051707267 > Looks like CI is failing. Please run `./gradlew spotlessApply` Done. Ready for review. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] reduce enum array allocation [iceberg]

2024-04-12 Thread via GitHub
nastra commented on PR #10126: URL: https://github.com/apache/iceberg/pull/10126#issuecomment-2051679635 Looks like CI is failing. Please run `./gradlew spotlessApply` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] reduce enum array allocation [iceberg]

2024-04-12 Thread via GitHub
sullis commented on PR #10126: URL: https://github.com/apache/iceberg/pull/10126#issuecomment-2051631396 > @sullis thanks for the improvement. I think it might make sense to also update other enums that do it like this. Could you please check the codebase and update those? Agreed. I