Re: [PR] open-api: Fix testFixtures dependencies [iceberg]

2024-10-29 Thread via GitHub
Fokko merged PR #11422: URL: https://github.com/apache/iceberg/pull/11422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] open-api: Fix testFixtures dependencies [iceberg]

2024-10-29 Thread via GitHub
Fokko commented on PR #11422: URL: https://github.com/apache/iceberg/pull/11422#issuecomment-2445022155 @ajantha-bhat Great catch, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] open-api: Fix testFixtures dependencies [iceberg]

2024-10-29 Thread via GitHub
ajantha-bhat commented on code in PR #11422: URL: https://github.com/apache/iceberg/pull/11422#discussion_r1820745009 ## build.gradle: ## @@ -973,10 +973,28 @@ project(':iceberg-open-api') { testFixturesImplementation project(':iceberg-api') testFixturesImplementation

Re: [PR] open-api: Fix testFixtures dependencies [iceberg]

2024-10-29 Thread via GitHub
ajantha-bhat commented on code in PR #11422: URL: https://github.com/apache/iceberg/pull/11422#discussion_r1820743221 ## build.gradle: ## @@ -973,10 +973,28 @@ project(':iceberg-open-api') { testFixturesImplementation project(':iceberg-api') testFixturesImplementation

Re: [PR] open-api: Fix testFixtures dependencies [iceberg]

2024-10-29 Thread via GitHub
ajantha-bhat commented on code in PR #11422: URL: https://github.com/apache/iceberg/pull/11422#discussion_r1820742624 ## build.gradle: ## @@ -973,10 +973,28 @@ project(':iceberg-open-api') { testFixturesImplementation project(':iceberg-api') testFixturesImplementation

Re: [PR] open-api: Fix testFixtures dependencies [iceberg]

2024-10-29 Thread via GitHub
ajantha-bhat commented on code in PR #11422: URL: https://github.com/apache/iceberg/pull/11422#discussion_r1820741909 ## build.gradle: ## @@ -973,10 +973,28 @@ project(':iceberg-open-api') { testFixturesImplementation project(':iceberg-api') testFixturesImplementation

[PR] open-api: Fix testFixtures dependencies [iceberg]

2024-10-29 Thread via GitHub
ajantha-bhat opened a new pull request, #11422: URL: https://github.com/apache/iceberg/pull/11422 Importing `testFixturesImplementation project(':iceberg-core').sourceSets.test.runtimeClasspath` brings everything to class path and creates problem for shadow jar. Need to depend