Fokko merged PR #740:
URL: https://github.com/apache/iceberg-rust/pull/740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko commented on code in PR #740:
URL: https://github.com/apache/iceberg-rust/pull/740#discussion_r1877958397
##
crates/iceberg/src/spec/name_mapping.rs:
##
@@ -0,0 +1,307 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
Fokko commented on code in PR #740:
URL: https://github.com/apache/iceberg-rust/pull/740#discussion_r1877955873
##
crates/iceberg/src/spec/mod.rs:
##
@@ -20,6 +20,7 @@
mod datatypes;
mod manifest;
mod manifest_list;
+mod name_mapping;
Review Comment:
I think we can add th
barronw commented on code in PR #740:
URL: https://github.com/apache/iceberg-rust/pull/740#discussion_r1862755672
##
crates/iceberg/src/spec/mod.rs:
##
@@ -20,6 +20,7 @@
mod datatypes;
mod manifest;
mod manifest_list;
+mod name_mapping;
Review Comment:
Please let me know
barronw commented on code in PR #740:
URL: https://github.com/apache/iceberg-rust/pull/740#discussion_r1862755672
##
crates/iceberg/src/spec/mod.rs:
##
@@ -20,6 +20,7 @@
mod datatypes;
mod manifest;
mod manifest_list;
+mod name_mapping;
Review Comment:
Please let me know
barronw commented on code in PR #740:
URL: https://github.com/apache/iceberg-rust/pull/740#discussion_r1862755672
##
crates/iceberg/src/spec/mod.rs:
##
@@ -20,6 +20,7 @@
mod datatypes;
mod manifest;
mod manifest_list;
+mod name_mapping;
Review Comment:
Please let me know
