Re: [PR] mr: Fix using Date type as partition field [iceberg]

2024-05-07 Thread via GitHub
nastra merged PR #10210: URL: https://github.com/apache/iceberg/pull/10210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] mr: Fix using Date type as partition field [iceberg]

2024-05-06 Thread via GitHub
lurnagao-dahua commented on PR #10210: URL: https://github.com/apache/iceberg/pull/10210#issuecomment-2095887589 @Fokko Hi, I am very much looking forward to and grateful for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] mr: Fix using Date type as partition field [iceberg]

2024-04-26 Thread via GitHub
lurnagao-dahua commented on PR #10210: URL: https://github.com/apache/iceberg/pull/10210#issuecomment-2078820125 @Fokko I am very much looking forward to and grateful for your review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] mr: Fix using Date type as partition field [iceberg]

2024-04-24 Thread via GitHub
lurnagao-dahua commented on code in PR #10210: URL: https://github.com/apache/iceberg/pull/10210#discussion_r1578796953 ## mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java: ## @@ -1206,6 +1208,55 @@ public void testRemoveAndAddBackColumnFr

Re: [PR] mr: Fix using Date type as partition field [iceberg]

2024-04-24 Thread via GitHub
nastra commented on code in PR #10210: URL: https://github.com/apache/iceberg/pull/10210#discussion_r1577928873 ## mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java: ## @@ -1206,6 +1208,55 @@ public void testRemoveAndAddBackColumnFromIceber

Re: [PR] mr: Fix using Date type as partition field [iceberg]

2024-04-24 Thread via GitHub
nastra commented on code in PR #10210: URL: https://github.com/apache/iceberg/pull/10210#discussion_r1577919902 ## mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java: ## @@ -1206,6 +1208,55 @@ public void testRemoveAndAddBackColumnFromIceber

Re: [PR] mr: Fix using Date type as partition field [iceberg]

2024-04-24 Thread via GitHub
nastra commented on code in PR #10210: URL: https://github.com/apache/iceberg/pull/10210#discussion_r1577918910 ## mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java: ## @@ -1206,6 +1208,55 @@ public void testRemoveAndAddBackColumnFromIceber

Re: [PR] mr: Fix using Date type as partition field [iceberg]

2024-04-24 Thread via GitHub
lurnagao-dahua commented on PR #10210: URL: https://github.com/apache/iceberg/pull/10210#issuecomment-2074824386 Hi, Can you take a look for me? @nastra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to