Fokko merged PR #211:
URL: https://github.com/apache/iceberg-python/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #211:
URL: https://github.com/apache/iceberg-python/pull/211#discussion_r1424978509
##
pyiceberg/table/__init__.py:
##
@@ -944,8 +944,8 @@ def snapshot(self) -> Optional[Snapshot]:
def projection(self) -> Schema:
snapshot_schema = self
tonyps1223 opened a new pull request, #211:
URL: https://github.com/apache/iceberg-python/pull/211
When given the first snapshot-id of the table, the schema got should have
schema_id = 0.
But under origin code's conditional statements, the use of walrus operator
will cause the condition
Tonylin1998 closed pull request #210: fix snapshot schema issue: wrong usage of
walrus operator
URL: https://github.com/apache/iceberg-python/pull/210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Tonylin1998 opened a new pull request, #210:
URL: https://github.com/apache/iceberg-python/pull/210
When given the first snapshot-id of the table, the schema got should have
schema_id = 0.
But under origin code's conditional statements, the use of walrus operator
will cause the condition