Re: [PR] fix adlss properties processing [iceberg-python]

2025-03-04 Thread via GitHub
Fokko merged PR #1732: URL: https://github.com/apache/iceberg-python/pull/1732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] fix adlss properties processing [iceberg-python]

2025-02-27 Thread via GitHub
Fokko commented on PR #1732: URL: https://github.com/apache/iceberg-python/pull/1732#issuecomment-2688907519 This is the equivalent code on the Java side of things: https://github.com/apache/iceberg/blob/a50ec923f3d928f67e2a4a361c0d1162341aa084/azure/src/main/java/org/apache/iceberg/azure/Az

Re: [PR] fix adlss properties processing [iceberg-python]

2025-02-27 Thread via GitHub
ms32035 commented on PR #1732: URL: https://github.com/apache/iceberg-python/pull/1732#issuecomment-2688762349 That probably would be a question to @Fokko who authored #1520 I'm not even sure what the correct property specification is (if any), and what other rest catalogs may return

Re: [PR] fix adlss properties processing [iceberg-python]

2025-02-27 Thread via GitHub
Fokko commented on PR #1732: URL: https://github.com/apache/iceberg-python/pull/1732#issuecomment-2688404050 @ms32035 Thank you for raising this. Can you also run `make lint`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] fix adlss properties processing [iceberg-python]

2025-02-27 Thread via GitHub
ms32035 opened a new pull request, #1732: URL: https://github.com/apache/iceberg-python/pull/1732 We observed that the property with token returned by Polaris is `adls.sas-token.` and the extra condition causes is to be ignored -- This is an automated message from the Apache Git Service.