Xuanwo merged PR #794:
URL: https://github.com/apache/iceberg-rust/pull/794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
Xuanwo commented on code in PR #794:
URL: https://github.com/apache/iceberg-rust/pull/794#discussion_r1884928592
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -128,7 +130,61 @@ pub struct ManifestWriter {
key_metadata: Vec,
-field_summary: HashMap,
+partitions:
ZENOTME commented on PR #794:
URL: https://github.com/apache/iceberg-rust/pull/794#issuecomment-2542949738
Thanks @Xuanwo's suggestion to make the code more clear!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
ZENOTME commented on code in PR #794:
URL: https://github.com/apache/iceberg-rust/pull/794#discussion_r1884917390
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -128,7 +130,61 @@ pub struct ManifestWriter {
key_metadata: Vec,
-field_summary: HashMap,
+partitions:
ZENOTME commented on code in PR #794:
URL: https://github.com/apache/iceberg-rust/pull/794#discussion_r1884874229
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -128,7 +130,61 @@ pub struct ManifestWriter {
key_metadata: Vec,
-field_summary: HashMap,
+partitions:
Xuanwo commented on code in PR #794:
URL: https://github.com/apache/iceberg-rust/pull/794#discussion_r1884853758
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -128,7 +130,61 @@ pub struct ManifestWriter {
key_metadata: Vec,
-field_summary: HashMap,
+partitions:
ZENOTME commented on PR #794:
URL: https://github.com/apache/iceberg-rust/pull/794#issuecomment-2541768726
cc @liurenjie1024 @Fokko @Xuanwo @sdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ZENOTME opened a new pull request, #794:
URL: https://github.com/apache/iceberg-rust/pull/794
Our computing way of partitions in the manifest is wrong. It should be a
list of field summaries for each partition field in the spec. Each field in the
list corresponds to a field in the manifest
