Re: [PR] fix: remove old, incorrect docstring [iceberg-python]

2024-09-12 Thread via GitHub
kevinjqliu commented on PR #1166: URL: https://github.com/apache/iceberg-python/pull/1166#issuecomment-2347119197 Hey there, found a couple more instances https://github.com/apache/iceberg-python/blob/d8d509ff1bc33040b9f6c90c28ee47ac7437945d/pyiceberg/catalog/__init__.py#L595

Re: [PR] fix: remove old, incorrect docstring [iceberg-python]

2024-09-12 Thread via GitHub
sungwy merged PR #1166: URL: https://github.com/apache/iceberg-python/pull/1166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] fix: remove old, incorrect docstring [iceberg-python]

2024-09-12 Thread via GitHub
sungwy commented on PR #1166: URL: https://github.com/apache/iceberg-python/pull/1166#issuecomment-2347072332 Thanks again for your contribution! @dataders -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] fix: remove old, incorrect docstring [iceberg-python]

2024-09-12 Thread via GitHub
sungwy commented on PR #1166: URL: https://github.com/apache/iceberg-python/pull/1166#issuecomment-2346965931 Hi @dataders thank you very much for identifying this issue and putting up this PR! For future information, the Contributing guidelines can be found here: https://py.iceberg.

Re: [PR] fix: remove old, incorrect docstring [iceberg-python]

2024-09-12 Thread via GitHub
dataders commented on PR #1166: URL: https://github.com/apache/iceberg-python/pull/1166#issuecomment-2346952281 @sungwy couldn't find any `CONTRIBUTING.md` or other guidance for contributions so let me know if I'm missing anything like a changelog entry -- This is an automated message fro

[PR] fix: remove old, incorrect docstring [iceberg-python]

2024-09-12 Thread via GitHub
dataders opened a new pull request, #1166: URL: https://github.com/apache/iceberg-python/pull/1166 resolves: #1163 remove this line. no additions necessary as other `Catalog` method's don't have additional context in the docstring beyond docmenting the signature -- This is an autom