Re: [PR] fix: page index evaluator min/max args inverted [iceberg-rust]

2024-09-26 Thread via GitHub
sdd commented on PR #648: URL: https://github.com/apache/iceberg-rust/pull/648#issuecomment-2376127462 @liurenjie1024 / @Xuanwo - would you be able to review this bug fix please? Without it, in some situations we return incorrect results when row selection is enabled. Thanks 😁 -- This i

[PR] fix: page index evaluator min/max args inverted [iceberg-rust]

2024-09-24 Thread via GitHub
sdd opened a new pull request, #648: URL: https://github.com/apache/iceberg-rust/pull/648 Fixes :https://github.com/apache/iceberg-rust/issues/647 I didn't catch all the places where I needed to change the order of the min / max args in an earlier refactor. Added a few more tes