kyteware commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2993069781
@liurenjie1024 Wow, you're totally right! I didn't realize you could do that
with cargo features. I'll make another PR to document this instead. Thanks for
the insight.
--
This i
liurenjie1024 commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2991638049
I'll close this issue for now as this is not the correct way to go. Feel
free to reopen it if you feel it necessary.
--
This is an automated message from the Apache Git Servi
liurenjie1024 closed pull request #1457: fix: include sqlite-required features
in sqlx dep
URL: https://github.com/apache/iceberg-rust/pull/1457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
liurenjie1024 commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2991634952
Thanks @kyteware for this pr, but I don't think this should be included in
iceberg. Default features of `sqlx` is disabled, so users are free to enable
`sqlx` features in their
kyteware commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2989387696
I would appreciate a re-run of the test CI, all tests pass but it looks like
the VM running it lost connection.
--
This is an automated message from the Apache Git Service.
To res
kyteware commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2989204156
I haven't fully investigated what the other features in `[dev-dependencies]`
for `sqlx` are needed for, but its possible that the rest of them should also
be included in the regular
kyteware opened a new pull request, #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457
## Which issue does this PR close?
- Closes #1456.
## What changes are included in this PR?
- Included the needed dependencies to the sql catalog crate
