Re: [PR] fix: compile error due to merge stale PR [iceberg-rust]

2024-09-24 Thread via GitHub
Xuanwo commented on PR #646: URL: https://github.com/apache/iceberg-rust/pull/646#issuecomment-2371271788 > @Xuanwo @liurenjie1024 @sdd Should we add "require PR to be up to date" or "merge queue"? (I prefer merge queue if possible) I will try contact with the INFRA for this. -- Th

Re: [PR] fix: compile error due to merge stale PR [iceberg-rust]

2024-09-24 Thread via GitHub
Xuanwo merged PR #646: URL: https://github.com/apache/iceberg-rust/pull/646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] fix: compile error due to merge stale PR [iceberg-rust]

2024-09-24 Thread via GitHub
xxchan commented on PR #646: URL: https://github.com/apache/iceberg-rust/pull/646#issuecomment-2371017171 @Xuanwo @liurenjie1024 @sdd Should we add "require PR to be up to date" or "merge queue"? (I prefer merge queue if possible) -- This is an automated message from the Apache Git Servic

Re: [PR] fix: compile error due to merge stale PR [iceberg-rust]

2024-09-24 Thread via GitHub
xxchan commented on code in PR #646: URL: https://github.com/apache/iceberg-rust/pull/646#discussion_r1773169760 ## crates/iceberg/src/arrow/reader.rs: ## @@ -245,7 +245,7 @@ impl ArrowReader { record_batch_stream_builder.metadata(), &se

Re: [PR] fix: compile error due to merge stale PR [iceberg-rust]

2024-09-24 Thread via GitHub
xxchan commented on code in PR #646: URL: https://github.com/apache/iceberg-rust/pull/646#discussion_r1773169008 ## crates/iceberg/src/expr/visitors/page_index_evaluator.rs: ## @@ -24,14 +24,14 @@ use ordered_float::OrderedFloat; use parquet::arrow::arrow_reader::{RowSelection,