nastra merged PR #145:
URL: https://github.com/apache/iceberg-go/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
zeroshade commented on PR #145:
URL: https://github.com/apache/iceberg-go/pull/145#issuecomment-2349659281
Okay, in that case i think it's fine to merge this as is without the tests
for now until we can figure out how to write tests using `pterm`.
Thanks @alex-kar and feel free to cre
alex-kar commented on PR #145:
URL: https://github.com/apache/iceberg-go/pull/145#issuecomment-2348837415
@zeroshade Same result
```
func ExampleDescribeTable() {
meta, _ := table.ParseMetadataBytes([]byte(ExampleTableMetadataV1))
table := table.New([]string{"t"}, meta,
zeroshade commented on PR #145:
URL: https://github.com/apache/iceberg-go/pull/145#issuecomment-2343773844
@alex-kar we could probably leverage "testable examples"
https://go.dev/blog/examples with go and just use `// Output:` stuff to point
out our expected output.
--
This is an automat
alex-kar commented on PR #145:
URL: https://github.com/apache/iceberg-go/pull/145#issuecomment-2342624384
@zeroshade Could you help me organize unit tests for `output.go`? I was
looking at how tests are organized in `github.com/pterm/pterm`, which prints
results in the terminal, and noticed
alex-kar opened a new pull request, #145:
URL: https://github.com/apache/iceberg-go/pull/145
Empty table does not have "Current Snapshot" causing describe command to be
failed.
Added validation to replace with empty string `""`.
Steps to reproduce
1. Start env `docker-compos
