Re: [PR] feat: support to append delete type data file [iceberg-rust]

2024-12-22 Thread via GitHub
ZENOTME commented on PR #798: URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2558853987 > > Is it possible to have action like combing fast append and append delete file and data file? In fact, I try this in practice and it can be read by spark. And for this action, I thi

Re: [PR] feat: support to append delete type data file [iceberg-rust]

2024-12-22 Thread via GitHub
liurenjie1024 commented on PR #798: URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2558786292 > Is it possible to have action like combing fast append and append delete file and data file? In fact, I try this in practice and it can be read by spark. And for this action, I

Re: [PR] feat: support to append delete type data file [iceberg-rust]

2024-12-20 Thread via GitHub
ZENOTME commented on PR #798: URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2558014970 > Thanks @ZENOTME for this pr! Adding support for deletion is a complicated process, which involves conflict detection, commit retries. I would suggest to have sth like you mention bui

Re: [PR] feat: support to append delete type data file [iceberg-rust]

2024-12-20 Thread via GitHub
liurenjie1024 commented on PR #798: URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2557983364 Thanks @ZENOTME for this pr! Adding support for deletion is a complicated process, which involves conflict detection, commit retries. I would suggest to have sth like you mention

Re: [PR] feat: support to append delete type data file [iceberg-rust]

2024-12-14 Thread via GitHub
ZENOTME commented on PR #798: URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2543013550 I noticed that MergingSnapshotProducer work like the MergeAppend, it will merge manifest when commit. Is that necessary for RowDelta?🤔 Can we implement RowDelta works like FastAppend b

Re: [PR] feat: support to append delete type data file [iceberg-rust]

2024-12-13 Thread via GitHub
ZENOTME commented on PR #798: URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2542902331 Sorry, I think I have some misunderstanding here since the action which support to append data file and delete file is RowDelta.🤔 So I guess what we need is right: 1. MergingSnapsho

Re: [PR] feat: support to append delete type data file [iceberg-rust]

2024-12-13 Thread via GitHub
ZENOTME commented on PR #798: URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2541922752 cc @liurenjie1024 @Xuanwo @Fokko @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] feat: support to append delete type data file [iceberg-rust]

2024-12-13 Thread via GitHub
ZENOTME opened a new pull request, #798: URL: https://github.com/apache/iceberg-rust/pull/798 This PR support to support to append delete type data file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to