Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

Fokko merged PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

Fokko commented on PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#issuecomment-2917339595 LGTM @dongxiao1198 , thanks for the review @wgtmac, @lidavidm and @yingcai-cy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

wgtmac commented on PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#issuecomment-2914954957 Iceberg itself only requires gzip for metadata json file. Specific file format libraries we use for Parquet and Avro have already supported different codecs so we don't need to deal with

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

wgtmac commented on PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#issuecomment-2914712436 @lidavidm @yingcai-cy Do you have any other comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

wgtmac commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2108002007 ## src/iceberg/util/gzip_internal.cc: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

dongxiao1198 commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2107001574 ## src/iceberg/util/gzip_internal.cc: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

yingcai-cy commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2106756398 ## src/iceberg/util/gzip_internal.cc: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

yingcai-cy commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2103886619 ## src/iceberg/table_metadata.cc: ## @@ -153,14 +154,70 @@ Result TableMetadataUtil::CodecFromFileName( return MetadataFileCodecType::kNone; } +class GZipDe

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

wgtmac commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2106515316 ## src/iceberg/util/gzip_internal.cc: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

dongxiao1198 commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2106439616 ## src/iceberg/table_metadata.cc: ## @@ -153,14 +154,70 @@ Result TableMetadataUtil::CodecFromFileName( return MetadataFileCodecType::kNone; } +class GZip

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

wgtmac commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2106412663 ## src/iceberg/table_metadata.cc: ## @@ -153,14 +154,70 @@ Result TableMetadataUtil::CodecFromFileName( return MetadataFileCodecType::kNone; } +class GZipDecomp

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

dongxiao1198 commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2104035641 ## src/iceberg/table_metadata.cc: ## @@ -153,14 +155,42 @@ Result TableMetadataUtil::CodecFromFileName( return MetadataFileCodecType::kNone; } +Result Dec

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

lidavidm commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2104016736 ## src/iceberg/table_metadata.cc: ## @@ -153,14 +155,42 @@ Result TableMetadataUtil::CodecFromFileName( return MetadataFileCodecType::kNone; } +Result Decompr

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

yingcai-cy commented on code in PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#discussion_r2103886619 ## src/iceberg/table_metadata.cc: ## @@ -153,14 +154,70 @@ Result TableMetadataUtil::CodecFromFileName( return MetadataFileCodecType::kNone; } +class GZipDe

[PR] feat: support decompress gzip metadata [iceberg-cpp]

dongxiao1198 opened a new pull request, #108: URL: https://github.com/apache/iceberg-cpp/pull/108 support gzip compressed metadata json -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi