kevinjqliu commented on PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542#issuecomment-2606171821
Thanks for the contribution @jayceslesar! and thanks for the review @Fokko :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kevinjqliu merged PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
jayceslesar commented on PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542#issuecomment-2604763110
this introduces sort of a tricky typing problem...
```
tests/expressions/test_literals.py:910: error: Value of type variable "L" of
"literal" cannot be "datetime" [type-v
Fokko commented on code in PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542#discussion_r1923485776
##
pyiceberg/expressions/literals.py:
##
@@ -145,6 +147,8 @@ def literal(value: L) -> Literal[L]:
return BinaryLiteral(value)
elif isinstance(value,
jayceslesar commented on code in PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542#discussion_r1922933602
##
tests/integration/test_reads.py:
##
@@ -950,3 +951,30 @@ def test_read_from_s3_and_local_fs(catalog: Catalog,
tmp_path: PosixPath) -> Non
result_t
jayceslesar commented on code in PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542#discussion_r1922933152
##
tests/integration/test_reads.py:
##
@@ -950,3 +951,11 @@ def test_read_from_s3_and_local_fs(catalog: Catalog,
tmp_path: PosixPath) -> Non
result_t
kevinjqliu commented on code in PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542#discussion_r1922894009
##
tests/integration/test_reads.py:
##
@@ -950,3 +951,11 @@ def test_read_from_s3_and_local_fs(catalog: Catalog,
tmp_path: PosixPath) -> Non
result_ta
jayceslesar commented on PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542#issuecomment-2603317427
> Thanks for the PR! Lets add a test for the example in the description with
`row_filter`
Added, let me know if we want anything more explicit there
--
This is an auto
kevinjqliu commented on PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542#issuecomment-2603291726
Thanks for the PR! Lets add a test for the example in the description with
`row_filter`
--
This is an automated message from the Apache Git Service.
To respond to the message,
