Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-13 Thread via GitHub
Xuanwo merged PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-13 Thread via GitHub
zhjwpku commented on PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#issuecomment-2800463163 @Fokko @Xuanwo I think the community have reached the consensus, and I have resolved the merge conflict, it would be great if you can help merge this, thanks. -- This is an automated m

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-13 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2041395083 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-13 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2041360622 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-13 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2041248649 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-13 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2041247562 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-11 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2039696196 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-11 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2039838319 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-11 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2039446143 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038719645 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038712261 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038710982 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038710036 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038700982 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038691575 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038692112 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038669952 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038669023 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038666126 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038649060 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2038648772 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2032108597 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033352992 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
Fokko commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2037642716 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2037621101 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
Fokko commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2037651164 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2037620418 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2037619220 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-10 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2037397838 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-09 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2036336978 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-09 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2035537020 ## src/iceberg/snapshot_ref.h: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-09 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2035537509 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-09 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2035536424 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-09 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2035535306 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2034347253 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2034353097 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2034367975 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033412007 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033454281 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033388253 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033411442 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033412940 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033413387 ## src/iceberg/snapshot_ref.h: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033408747 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033378953 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033378026 ## src/iceberg/snapshot_ref.h: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033373246 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033357793 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033358606 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2032235416 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
gty404 commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033044507 ## src/iceberg/snapshot_ref.h: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-07 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2032252983 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

[PR] feat: snapshot [iceberg-cpp]

2025-04-07 Thread via GitHub
zhjwpku opened a new pull request, #60: URL: https://github.com/apache/iceberg-cpp/pull/60 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma