Re: [PR] feat: metadata access support for table [iceberg-cpp]

zhjwpku commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2161697814 ## src/iceberg/table.h: ## @@ -19,13 +19,14 @@ #pragma once -#include +#include Review Comment: I don't see any usage of mutex, what's the intent here?

Re: [PR] feat: metadata access support for table [iceberg-cpp]

zhjwpku commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2161688458 ## src/iceberg/table.cc: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: metadata access support for table [iceberg-cpp]

wgtmac commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2160751825 ## src/iceberg/table.h: ## @@ -35,77 +36,88 @@ class ICEBERG_EXPORT Table { public: virtual ~Table() = default; - /// \brief Return the full name for this tabl

Re: [PR] feat: metadata access support for table [iceberg-cpp]

wgtmac commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2156289324 ## src/iceberg/type_fwd.h: ## @@ -99,6 +99,9 @@ class TransformFunction; struct PartitionStatisticsFile; struct Snapshot; struct SnapshotRef; +struct SnapshotLogEnt