liurenjie1024 merged PR #377:
URL: https://github.com/apache/iceberg-rust/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Fokko commented on PR #377:
URL: https://github.com/apache/iceberg-rust/pull/377#issuecomment-2132797415
I'm in favor of this change since this will keep the API much cleaner. The
ManifestEntry will change over time, maybe good to keep Iceberg-specific things
out of there. The pattern of th
liurenjie1024 commented on PR #377:
URL: https://github.com/apache/iceberg-rust/pull/377#issuecomment-2129114452
I think the idea looks good to me, but I'm not sure if we should modify
`FileScanTask` now. Should we postpone this until we start to integrate with a
true engine such as datafus
Fokko commented on code in PR #377:
URL: https://github.com/apache/iceberg-rust/pull/377#discussion_r1611209532
##
crates/iceberg/src/scan.rs:
##
@@ -463,18 +464,19 @@ impl ManifestEvaluatorCache {
}
/// A task to scan part of file.
-#[derive(Debug)]
+#[derive(Debug, Clone,
ZENOTME commented on PR #377:
URL: https://github.com/apache/iceberg-rust/pull/377#issuecomment-2123974633
> This seems reasonable, but perhaps we might want to consider having this
as a separate method to the existing `plan_files` though so that anyone who is
using the existing stream of f
sdd commented on PR #377:
URL: https://github.com/apache/iceberg-rust/pull/377#issuecomment-2123920187
This seems reasonable, but perhaps we might want to consider having this as
a separate method to the existing `plan_files` though so that anyone who is
using the existing stream of file pl
ZENOTME commented on PR #377:
URL: https://github.com/apache/iceberg-rust/pull/377#issuecomment-2122049316
cc @liurenjie1024 @Fokko @Xuanwo @sdd @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ZENOTME opened a new pull request, #377:
URL: https://github.com/apache/iceberg-rust/pull/377
There is a user case of file scan task for the compute engine:
1. compute the file scan task and shuffle them to the compute node
2. The compute node does the scan work in parallel
In
