liurenjie1024 commented on PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#issuecomment-2177358785
Thanks @ZENOTME for this effort, and @sdd for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
liurenjie1024 merged PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
sdd commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1644888305
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
liurenjie1024 commented on PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#issuecomment-2176223197
cc @sdd Do you have other concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
liurenjie1024 commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1644548426
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
ZENOTME commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1643733387
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
liurenjie1024 commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1643677799
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
ZENOTME commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1643673503
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
ZENOTME commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1643673503
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
liurenjie1024 commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1643647234
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
ZENOTME commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1642947050
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
ZENOTME commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1642947050
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
ZENOTME commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1642947050
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
liurenjie1024 commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1642925017
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
liurenjie1024 commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1642916388
##
crates/iceberg/src/spec/values.rs:
##
@@ -105,6 +108,115 @@ pub struct Datum {
literal: PrimitiveLiteral,
}
+impl Serialize for Datum {
+fn seri
liurenjie1024 commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1642914543
##
crates/iceberg/src/spec/values.rs:
##
@@ -105,6 +108,115 @@ pub struct Datum {
literal: PrimitiveLiteral,
}
+impl Serialize for Datum {
+fn seri
sdd commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1642258305
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
sdd commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1642245641
##
crates/iceberg/src/spec/values.rs:
##
@@ -2334,9 +2453,20 @@ mod _serde {
},
RawLiteralEnum::Float(v) => match ty {
sdd commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1642234401
##
crates/iceberg/src/spec/values.rs:
##
@@ -105,6 +108,115 @@ pub struct Datum {
literal: PrimitiveLiteral,
}
+impl Serialize for Datum {
+fn serialize(
+
ZENOTME commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1641901794
##
crates/iceberg/src/spec/values.rs:
##
@@ -105,6 +108,115 @@ pub struct Datum {
literal: PrimitiveLiteral,
}
+impl Serialize for Datum {
+fn serialize(
ZENOTME commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1641888209
##
crates/iceberg/src/spec/values.rs:
##
@@ -105,6 +108,115 @@ pub struct Datum {
literal: PrimitiveLiteral,
}
+impl Serialize for Datum {
+fn serialize(
liurenjie1024 commented on code in PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#discussion_r1641882147
##
crates/iceberg/src/spec/values.rs:
##
@@ -105,6 +108,115 @@ pub struct Datum {
literal: PrimitiveLiteral,
}
+impl Serialize for Datum {
+fn seri
ZENOTME commented on PR #406:
URL: https://github.com/apache/iceberg-rust/pull/406#issuecomment-2171685472
cc @liurenjie1024 @sdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
23 matches
Mail list logo
