liurenjie1024 merged PR #524:
URL: https://github.com/apache/iceberg-rust/pull/524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Xuanwo commented on PR #524:
URL: https://github.com/apache/iceberg-rust/pull/524#issuecomment-2275718809
Inviting @liurenjie1024 for a second review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
callum-ryan commented on code in PR #524:
URL: https://github.com/apache/iceberg-rust/pull/524#discussion_r1705944560
##
crates/catalog/sql/src/catalog.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
callum-ryan commented on code in PR #524:
URL: https://github.com/apache/iceberg-rust/pull/524#discussion_r1705912242
##
crates/catalog/sql/src/catalog.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
Xuanwo commented on code in PR #524:
URL: https://github.com/apache/iceberg-rust/pull/524#discussion_r1704882565
##
crates/catalog/sql/Cargo.toml:
##
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See th
callum-ryan opened a new pull request, #524:
URL: https://github.com/apache/iceberg-rust/pull/524
As discussed in [PR503](https://github.com/apache/iceberg-rust/pull/503) -
splitting out SQL catalog PRs to make development + review easier.
Addressed @Xuanwo's comments about formatting
