liurenjie1024 merged PR #262:
URL: https://github.com/apache/iceberg-rust/pull/262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
marvinlanhenke commented on PR #262:
URL: https://github.com/apache/iceberg-rust/pull/262#issuecomment-1996606877
@ZENOTME
thanks so much for your work - this will definitely unblock me.
> We can left the binding to other pr, and forbid table creation with
partition spec and sort orde
marvinlanhenke commented on code in PR #262:
URL: https://github.com/apache/iceberg-rust/pull/262#discussion_r1524291618
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -275,6 +277,82 @@ impl TableMetadata {
}
}
+/// Manipulating table metadata.
+pub struct TableMeta
liurenjie1024 commented on code in PR #262:
URL: https://github.com/apache/iceberg-rust/pull/262#discussion_r1524213529
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -275,6 +277,82 @@ impl TableMetadata {
}
}
+/// Manipulating table metadata.
+pub struct TableMetad
ZENOTME commented on code in PR #262:
URL: https://github.com/apache/iceberg-rust/pull/262#discussion_r1524159851
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -275,6 +277,82 @@ impl TableMetadata {
}
}
+/// Manipulating table metadata.
+pub struct TableMetadataBui
liurenjie1024 commented on code in PR #262:
URL: https://github.com/apache/iceberg-rust/pull/262#discussion_r1524157344
##
crates/iceberg/src/spec/partition.rs:
##
@@ -133,6 +133,25 @@ impl UnboundPartitionSpec {
pub fn builder() -> UnboundPartitionSpecBuilder {
Un
ZENOTME commented on PR #262:
URL: https://github.com/apache/iceberg-rust/pull/262#issuecomment-1996316028
> We can left the binding to other pr, and forbid table creation with
partition spec and sort order for now, it's up to you.
Let's forbid them now. I think I'm not clear with th
liurenjie1024 commented on PR #262:
URL: https://github.com/apache/iceberg-rust/pull/262#issuecomment-1996240458
cc @marvinlanhenke @Fokko @Xuanwo PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
liurenjie1024 commented on code in PR #262:
URL: https://github.com/apache/iceberg-rust/pull/262#discussion_r1524080929
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -275,6 +277,78 @@ impl TableMetadata {
}
}
+/// Manipulating table metadata.
+pub struct TableMetad
ZENOTME opened a new pull request, #262:
URL: https://github.com/apache/iceberg-rust/pull/262
This PR init TableMetadataBuilder. Complete #250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
10 matches
Mail list logo