Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-07-15 Thread via GitHub
zhjwpku commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2207162468 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType()

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-07-14 Thread via GitHub
gty404 commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2205091751 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType() c

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-07-08 Thread via GitHub
wgtmac commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2191686788 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType() c

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-07-07 Thread via GitHub
zhjwpku commented on PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#issuecomment-3045327668 > The type objects in test can also be modified to singleton. Yeah, that's an oversight, fixed. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-07-07 Thread via GitHub
zhjwpku commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2190194867 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType()

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-30 Thread via GitHub
lidavidm commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2174504581 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType()

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
raulcd commented on PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#issuecomment-3018011425 > We have seen quite a lot timeout from downloading thrift-0.20.0. Should we fix this in the Arrow repo to use more stable URL? @lidavidm @raulcd There is an issue and a WIP PR (so

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
zhjwpku commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2174339367 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType()

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
zhjwpku commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2174339367 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType()

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
gty404 commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2174108999 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType() c

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
wgtmac commented on PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#issuecomment-3016740262 cc @gty404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
wgtmac commented on PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#issuecomment-3016738053 ``` Connection #0 to host www.apache.org left intact Issue another request to this URL: 'https://archive.apache.org/dist/thrift/0.20.0/thrift-0.20.0.tar.gz' tim

[PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
zhjwpku opened a new pull request, #132: URL: https://github.com/apache/iceberg-cpp/pull/132 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-