liurenjie1024 merged PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Dysprosium0626 commented on PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#issuecomment-2016786945
> LGTM, thanks!
Thank you very much for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Dysprosium0626 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1536798548
##
crates/iceberg/src/spec/schema.rs:
##
@@ -642,6 +644,204 @@ impl SchemaVisitor for IndexByName {
}
}
+struct PruneColumn {
+selected: HashSet,
liurenjie1024 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1536788615
##
crates/iceberg/src/spec/schema.rs:
##
@@ -642,6 +644,204 @@ impl SchemaVisitor for IndexByName {
}
}
+struct PruneColumn {
+selected: HashSet,
+
Dysprosium0626 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1535803356
##
crates/iceberg/src/spec/schema.rs:
##
@@ -642,6 +644,204 @@ impl SchemaVisitor for IndexByName {
}
}
+struct PruneColumn {
+selected: HashSet,
liurenjie1024 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1535397546
##
crates/iceberg/src/spec/schema.rs:
##
@@ -642,6 +644,204 @@ impl SchemaVisitor for IndexByName {
}
}
+struct PruneColumn {
+selected: HashSet,
+
liurenjie1024 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1533943697
##
crates/iceberg/src/spec/schema.rs:
##
@@ -642,6 +644,199 @@ impl SchemaVisitor for IndexByName {
}
}
+struct PruneColumn {
+selected: HashSet,
+
liurenjie1024 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1533942476
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1338,4 +1533,430 @@ table {
);
}
}
+#[test]
+fn test_schema_prune_columns_strin
Dysprosium0626 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1533718813
##
crates/iceberg/src/spec/schema.rs:
##
@@ -642,6 +644,199 @@ impl SchemaVisitor for IndexByName {
}
}
+struct PruneColumn {
+selected: HashSet,
Dysprosium0626 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1533685816
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1338,4 +1533,430 @@ table {
);
}
}
+#[test]
+fn test_schema_prune_columns_stri
liurenjie1024 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1531709362
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1338,4 +1533,430 @@ table {
);
}
}
+#[test]
+fn test_schema_prune_columns_strin
11 matches
Mail list logo
