kevinjqliu commented on PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140#issuecomment-2648727031
Thanks for the contribution @hussein-awala and thanks for the review @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kevinjqliu merged PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
Fokko commented on PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140#issuecomment-2647563540
Or just:
```python
catalog = load_catalog('default', 'type'='in-memory',
'warehouse'='/tmp/pyiceberg/warehouse')
```
I agree that this catalog impl is mostly focussed
hussein-awala commented on code in PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140#discussion_r1947182388
##
tests/catalog/test_memory.py:
##
@@ -278,17 +62,20 @@ def catalog(tmp_path: PosixPath) -> InMemoryCatalog:
)
TEST_TABLE_PARTITION_SPEC = PartitionSpec
hussein-awala commented on PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140#issuecomment-2644093341
> hey @hussein-awala would you like to make the above changes on docs? This
PR is almost ready!
yes, I will make it ready ASAP
--
This is an automated message from t
kevinjqliu commented on PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140#issuecomment-2628601396
hey @hussein-awala would you like to make the above changes on docs? This PR
is almost ready!
--
This is an automated message from the Apache Git Service.
To respond to the m
kevinjqliu commented on PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140#issuecomment-2442147026
> I'm positive about this change. The only consideration I could make is
that we hide the SqlCatalog behind the InMemoryCatalog. Maybe it is interesting
for folks to know that t
Fokko commented on PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140#issuecomment-2441769329
@hussein-awala Thanks for working on this 🚀 @kevinjqliu Regarding the new
catalogs, my main concern was a proliferation of new catalogs, and that they
would lack maintenance. I do l
kevinjqliu commented on code in PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140#discussion_r1757497999
##
tests/catalog/test_memory.py:
##
@@ -607,7 +400,7 @@ def test_list_tables(catalog: InMemoryCatalog) -> None:
# Given
given_catalog_has_a_table(ca
hussein-awala commented on PR #1140:
URL: https://github.com/apache/iceberg-python/pull/1140#issuecomment-2334705664
@kevinjqliu I applied what you suggested in the comment above, could you
recheck it now?
--
This is an automated message from the Apache Git Service.
To respond to the mess
10 matches
Mail list logo
