Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-06-05 Thread via GitHub
yingcai-cy commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2128307241 ## src/iceberg/table_scan.cc: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-05-29 Thread via GitHub
wgtmac commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2115013977 ## src/iceberg/table_scan.h: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-05-28 Thread via GitHub
gty404 commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2113019823 ## src/iceberg/table_scan.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-05-27 Thread via GitHub
wgtmac commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2110719450 ## src/iceberg/table_scan.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-05-27 Thread via GitHub
lidavidm commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2110599021 ## src/iceberg/table_scan.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-05-27 Thread via GitHub
gty404 commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2108542013 ## src/iceberg/result.h: ## @@ -31,6 +31,7 @@ namespace iceberg { enum class ErrorKind { kAlreadyExists, kCommitStateUnknown, + kDataInvalid, Review Comment:

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-05-27 Thread via GitHub
lidavidm commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2108439814 ## src/iceberg/result.h: ## @@ -31,6 +31,7 @@ namespace iceberg { enum class ErrorKind { kAlreadyExists, kCommitStateUnknown, + kDataInvalid, Review Comment

[PR] feat: basic table scan planning [iceberg-cpp]

2025-05-26 Thread via GitHub
gty404 opened a new pull request, #112: URL: https://github.com/apache/iceberg-cpp/pull/112 Introducing basic scan table data interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi