Fokko merged PR #101:
URL: https://github.com/apache/iceberg-cpp/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
dongxiao1198 commented on code in PR #101:
URL: https://github.com/apache/iceberg-cpp/pull/101#discussion_r2095224359
##
cmake_modules/IcebergThirdpartyToolchain.cmake:
##
@@ -86,6 +86,9 @@ function(resolve_arrow_dependency)
set(ARROW_DEPENDENCY_SOURCE
"BUNDLED"
wgtmac commented on code in PR #101:
URL: https://github.com/apache/iceberg-cpp/pull/101#discussion_r2095220979
##
cmake_modules/IcebergThirdpartyToolchain.cmake:
##
@@ -285,3 +287,20 @@ function(resolve_nlohmann_json_dependency)
endfunction()
resolve_nlohmann_json_dependenc
dongxiao1198 commented on code in PR #101:
URL: https://github.com/apache/iceberg-cpp/pull/101#discussion_r2095290384
##
cmake_modules/IcebergThirdpartyToolchain.cmake:
##
@@ -285,3 +287,20 @@ function(resolve_nlohmann_json_dependency)
endfunction()
resolve_nlohmann_json_dep
dongxiao1198 commented on code in PR #101:
URL: https://github.com/apache/iceberg-cpp/pull/101#discussion_r2095292516
##
cmake_modules/IcebergThirdpartyToolchain.cmake:
##
@@ -285,3 +287,20 @@ function(resolve_nlohmann_json_dependency)
endfunction()
resolve_nlohmann_json_dep
wgtmac commented on code in PR #101:
URL: https://github.com/apache/iceberg-cpp/pull/101#discussion_r2095218184
##
cmake_modules/IcebergThirdpartyToolchain.cmake:
##
@@ -285,3 +287,20 @@ function(resolve_nlohmann_json_dependency)
endfunction()
resolve_nlohmann_json_dependenc
wgtmac commented on code in PR #101:
URL: https://github.com/apache/iceberg-cpp/pull/101#discussion_r2095044690
##
cmake_modules/IcebergThirdpartyToolchain.cmake:
##
@@ -86,6 +86,9 @@ function(resolve_arrow_dependency)
set(ARROW_DEPENDENCY_SOURCE
"BUNDLED"
CACHE
