Re: [PR] feat: add visit type support [iceberg-cpp]

Xuanwo merged PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] feat: add visit type support [iceberg-cpp]

zhjwpku commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2084791404 ## src/iceberg/util/checked_cast.h: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] feat: add visit type support [iceberg-cpp]

Fokko commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2084155135 ## src/iceberg/util/checked_cast.h: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat: add visit type support [iceberg-cpp]

wgtmac commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083767328 ## src/iceberg/util/unreachable.h: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat: add visit type support [iceberg-cpp]

zhjwpku commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083761948 ## src/iceberg/util/unreachable.h: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] feat: add visit type support [iceberg-cpp]

zhjwpku commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083762155 ## src/iceberg/util/checked_cast.h: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] feat: add visit type support [iceberg-cpp]

wgtmac commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083718131 ## src/iceberg/util/checked_cast.h: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] feat: add visit type support [iceberg-cpp]

zhjwpku commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083097538 ## src/iceberg/util/visit_type.h: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] feat: add visit type support [iceberg-cpp]

lidavidm commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083072706 ## src/iceberg/util/visit_type.h: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] feat: add visit type support [iceberg-cpp]

zhjwpku commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083062041 ## src/iceberg/util/visit_type.h: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] feat: add visit type support [iceberg-cpp]

lidavidm commented on code in PR #94: URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2082993421 ## src/iceberg/util/visit_type.h: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

[PR] feat: add visit type support [iceberg-cpp]

zhjwpku opened a new pull request, #94: URL: https://github.com/apache/iceberg-cpp/pull/94 Add a `TypeId` field to each concrete type to enable macro-based type visitor support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub