liurenjie1024 merged PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on code in PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#discussion_r1539127406
##
crates/iceberg/src/transform/temporal.rs:
##
@@ -51,12 +57,48 @@ impl TransformFunction for Year {
.unary(|v| v - UNIX_EPOCH_YEAR),
ZENOTME commented on code in PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#discussion_r1539123455
##
crates/iceberg/src/transform/temporal.rs:
##
@@ -51,12 +57,48 @@ impl TransformFunction for Year {
.unary(|v| v - UNIX_EPOCH_YEAR),
))
liurenjie1024 commented on code in PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#discussion_r1538988833
##
crates/iceberg/src/transform/temporal.rs:
##
@@ -39,6 +38,13 @@ const UNIX_EPOCH_YEAR: i32 = 1970;
#[derive(Debug)]
pub struct Year;
+impl Year {
+#
ZENOTME commented on PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#issuecomment-2018117523
Thanks for your review! Have fixed it. @liurenjie1024 @marvinlanhenke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
liurenjie1024 commented on code in PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#discussion_r1533295727
##
crates/iceberg/src/transform/mod.rs:
##
@@ -31,6 +34,8 @@ pub trait TransformFunction: Send {
/// The implementation of this function will need to chec
ZENOTME commented on PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#issuecomment-2011287654
> I guess I can do that when implementing
https://github.com/apache/iceberg-rust/issues/264 since I need this anyway?
LGTM. Thanks!
--
This is an automated message from the Ap
marvinlanhenke commented on PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#issuecomment-2011235235
> So I think in here what we need is a function extract the reference of
literalš¤
I guess I can do that when implementing #264 since I need this anyway? Other
than that t
ZENOTME commented on PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#issuecomment-2011068196
> @ZENOTME Thank you for this PR. I think I can work with that.
>
> One question though, regarding the input: `&Literal` - I guess we do this,
due to the greater flexibility?
marvinlanhenke commented on PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#issuecomment-2010456207
@ZENOTME
Thank you for this PR. I think I can work with that.
One question though, regarding the input: `&Literal` - I guess we do this,
due to the greater flexibility
ZENOTME commented on PR #287:
URL: https://github.com/apache/iceberg-rust/pull/287#issuecomment-2009808470
cc @liurenjie1024 @Xuanwo @Fokko @marvinlanhenke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
11 matches
Mail list logo
