Fokko merged PR #85:
URL: https://github.com/apache/iceberg-cpp/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on PR #85:
URL: https://github.com/apache/iceberg-cpp/pull/85#issuecomment-2825304539
Thanks @wgtmac for working on this, and thanks @lidavidm, @zhjwpku and
@yingcai-cy for the review 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message,
wgtmac commented on code in PR #85:
URL: https://github.com/apache/iceberg-cpp/pull/85#discussion_r2056201530
##
src/iceberg/json_internal.cc:
##
@@ -1209,4 +1209,20 @@ Result>
TableMetadataFromJson(const nlohmann::jso
return table_metadata;
}
+Result FromJsonString(const
lidavidm commented on code in PR #85:
URL: https://github.com/apache/iceberg-cpp/pull/85#discussion_r2056113117
##
src/iceberg/json_internal.cc:
##
@@ -1209,4 +1209,20 @@ Result>
TableMetadataFromJson(const nlohmann::jso
return table_metadata;
}
+Result FromJsonString(con
wgtmac commented on code in PR #85:
URL: https://github.com/apache/iceberg-cpp/pull/85#discussion_r2055709443
##
src/iceberg/table_metadata.cc:
##
@@ -69,4 +76,100 @@ Result>
TableMetadata::SortOrder() const {
return *iter;
}
+namespace {
+
+template
+bool SharedPtrVecto
yingcai-cy commented on code in PR #85:
URL: https://github.com/apache/iceberg-cpp/pull/85#discussion_r2055695184
##
src/iceberg/table_metadata.cc:
##
@@ -69,4 +76,100 @@ Result>
TableMetadata::SortOrder() const {
return *iter;
}
+namespace {
+
+template
+bool SharedPtrV
wgtmac commented on code in PR #85:
URL: https://github.com/apache/iceberg-cpp/pull/85#discussion_r2055693795
##
src/iceberg/json_internal.cc:
##
@@ -1209,4 +1209,20 @@ Result>
TableMetadataFromJson(const nlohmann::jso
return table_metadata;
}
+Result FromJsonString(const
yingcai-cy commented on code in PR #85:
URL: https://github.com/apache/iceberg-cpp/pull/85#discussion_r2055675024
##
src/iceberg/json_internal.cc:
##
@@ -1209,4 +1209,20 @@ Result>
TableMetadataFromJson(const nlohmann::jso
return table_metadata;
}
+Result FromJsonString(c
wgtmac commented on code in PR #85:
URL: https://github.com/apache/iceberg-cpp/pull/85#discussion_r2055223121
##
src/iceberg/table_metadata.h:
##
@@ -140,4 +141,29 @@ ICEBERG_EXPORT std::string ToString(const
SnapshotLogEntry& entry);
/// \brief Returns a string representation
