Re: [PR] feat: add spdlog dependency to implement logging [iceberg-cpp]

2025-07-13 Thread via GitHub
Xuanwo merged PR #140: URL: https://github.com/apache/iceberg-cpp/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] feat: add spdlog dependency to implement logging [iceberg-cpp]

2025-07-07 Thread via GitHub
yingcai-cy commented on PR #140: URL: https://github.com/apache/iceberg-cpp/pull/140#issuecomment-3047436848 +1 to pluggable logging interface,I'll take a look into this later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] feat: add spdlog dependency to implement logging [iceberg-cpp]

2025-07-07 Thread via GitHub
zhjwpku commented on PR #140: URL: https://github.com/apache/iceberg-cpp/pull/140#issuecomment-3045476250 +1 for adding the logger interface. It seems easier for iceberg, but for iceberg-bundle, the logger needs to handle not just iceberg but also libraries like Arrow, Avro, and others t

Re: [PR] feat: add spdlog dependency to implement logging [iceberg-cpp]

2025-07-06 Thread via GitHub
wgtmac commented on PR #140: URL: https://github.com/apache/iceberg-cpp/pull/140#issuecomment-3041805409 Perhaps we can design a pluggable logger interface so that downstream projects can plug in their own logger of choice. -- This is an automated message from the Apache Git Service. To r

Re: [PR] feat: add spdlog dependency to implement logging [iceberg-cpp]

2025-07-06 Thread via GitHub
Kelvinyu1117 commented on PR #140: URL: https://github.com/apache/iceberg-cpp/pull/140#issuecomment-3041156668 I would like to suggest another alternative: https://github.com/odygrd/quill I used this logger professionally for ultra low latency application, maybe we can have a look.

[PR] feat: add spdlog dependency to implement logging [iceberg-cpp]

2025-07-05 Thread via GitHub
wgtmac opened a new pull request, #140: URL: https://github.com/apache/iceberg-cpp/pull/140 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m