Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-05 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022528676 ## src/iceberg/transform.h: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-04 Thread via GitHub
lidavidm commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022281273 ## src/iceberg/transform.h: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
wgtmac commented on PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#issuecomment-2768372630 @lidavidm @zhjwpku @yingcai-cy Do you want to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
Fokko commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022929047 ## src/iceberg/transform.h: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
Fokko merged PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022757545 ## src/iceberg/transform.h: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
wgtmac commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022772982 ## src/iceberg/transform.h: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
Fokko commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022742209 ## src/iceberg/transform.h: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
Fokko commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022553647 ## src/iceberg/transform.h: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022570053 ## src/iceberg/transform.h: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
Fokko commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022515041 ## src/iceberg/transform.h: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
Fokko commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022513092 ## src/iceberg/transform.h: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
wgtmac commented on PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#issuecomment-2768674611 @Fokko @Xuanwo Could you help review and merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] feat: add partition field/partition spec [iceberg-cpp]

2025-04-01 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022288956 ## src/iceberg/transform.h: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the