Fokko commented on PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#issuecomment-2825301231
Thanks @wgtmac for working on this, and thanks @lidavidm, @zhjwpku and
@yingcai-cy for the review 🙌
--
This is an automated message from the Apache Git Service.
To respond to the messag
Fokko merged PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
lidavidm commented on PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#issuecomment-2823693191
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
wgtmac commented on code in PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#discussion_r2055662718
##
src/iceberg/util/formatter.h:
##
@@ -40,3 +43,102 @@ struct std::formatter :
std::formatter {
return std::formatter::format(obj.ToString(), ctx);
}
};
+
+//
wgtmac commented on PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#issuecomment-2823690624
I've moved specialization for std containers to the internal header file to
not pollute downstream. Let me know what you think @lidavidm
--
This is an automated message from the Apache
lidavidm commented on code in PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#discussion_r2055659276
##
src/iceberg/util/formatter.h:
##
@@ -40,3 +43,102 @@ struct std::formatter :
std::formatter {
return std::formatter::format(obj.ToString(), ctx);
}
};
+
+
lidavidm commented on code in PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#discussion_r2055658280
##
src/iceberg/util/formatter.h:
##
@@ -40,3 +43,102 @@ struct std::formatter :
std::formatter {
return std::formatter::format(obj.ToString(), ctx);
}
};
+
+
wgtmac commented on code in PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#discussion_r2055639146
##
src/iceberg/util/formatter.h:
##
@@ -40,3 +43,102 @@ struct std::formatter :
std::formatter {
return std::formatter::format(obj.ToString(), ctx);
}
};
+
+//
wgtmac commented on code in PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#discussion_r2055544216
##
src/iceberg/util/formatter.h:
##
@@ -40,3 +43,102 @@ struct std::formatter :
std::formatter {
return std::formatter::format(obj.ToString(), ctx);
}
};
+
+//
lidavidm commented on code in PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#discussion_r2055474145
##
test/formatter_test.cc:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the
10 matches
Mail list logo
