Re: [PR] feat: add file reader interface [iceberg-cpp]

Fokko merged PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] feat: add file reader interface [iceberg-cpp]

wgtmac commented on code in PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2065743774 ## src/iceberg/file_format.h: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: add file reader interface [iceberg-cpp]

Fokko commented on code in PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2065738873 ## src/iceberg/file_format.h: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: add file reader interface [iceberg-cpp]

wgtmac commented on code in PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2063703993 ## src/iceberg/file_reader.h: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: add file reader interface [iceberg-cpp]

zhjwpku commented on code in PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2063413027 ## src/iceberg/file_format.h: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: add file reader interface [iceberg-cpp]

zhjwpku commented on code in PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2063413027 ## src/iceberg/file_format.h: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: add file reader interface [iceberg-cpp]

zhjwpku commented on code in PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2063402036 ## src/iceberg/file_format.h: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: add file reader interface [iceberg-cpp]

lidavidm commented on code in PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2062574097 ## src/iceberg/file_reader.h: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add file reader interface [iceberg-cpp]

wgtmac commented on code in PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2061940987 ## src/iceberg/file_reader.h: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] feat: add file reader interface [iceberg-cpp]

lidavidm commented on code in PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2061916317 ## src/iceberg/file_reader.h: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add file reader interface [iceberg-cpp]

wgtmac commented on PR #88: URL: https://github.com/apache/iceberg-cpp/pull/88#issuecomment-2831908914 @lidavidm @zhjwpku Could you help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go