Re: [PR] feat: add construct_ref for table_metadata [iceberg-rust]

2025-03-07 Thread via GitHub
Fokko commented on PR #1043: URL: https://github.com/apache/iceberg-rust/pull/1043#issuecomment-2706390034 Thanks @ZENOTME 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat: add construct_ref for table_metadata [iceberg-rust]

2025-03-07 Thread via GitHub
Fokko merged PR #1043: URL: https://github.com/apache/iceberg-rust/pull/1043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] feat: add construct_ref for table_metadata [iceberg-rust]

2025-03-07 Thread via GitHub
ZENOTME commented on PR #1043: URL: https://github.com/apache/iceberg-rust/pull/1043#issuecomment-2705997518 > LGTM, should we throw in a test? Have added the test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] feat: add construct_ref for table_metadata [iceberg-rust]

2025-03-05 Thread via GitHub
ZENOTME commented on PR #1043: URL: https://github.com/apache/iceberg-rust/pull/1043#issuecomment-2700349589 cc @liurenjie1024 @Xuanwo @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] feat: add construct_ref for table_metadata [iceberg-rust]

2025-03-05 Thread via GitHub
ZENOTME opened a new pull request, #1043: URL: https://github.com/apache/iceberg-rust/pull/1043 ## Which issue does this PR close? ## What changes are included in this PR? This PR add a construct_ref to insert the main branch if it's not found in refs. ref f