Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-21 Thread via GitHub
Fokko merged PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-21 Thread via GitHub
wgtmac commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2100391479 ## src/iceberg/avro/avro_stream_internal.h: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-21 Thread via GitHub
Fokko commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2100146204 ## src/iceberg/avro/avro_stream_internal.h: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agree

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-21 Thread via GitHub
dongxiao1198 commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2099742048 ## src/iceberg/avro/avro_stream_internal.cc: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor lice

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-21 Thread via GitHub
dongxiao1198 commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2099736864 ## src/iceberg/avro/avro_stream_internal.cc: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor lice

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-21 Thread via GitHub
zhjwpku commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2099721432 ## src/iceberg/avro/avro_stream_internal.cc: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license a

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-21 Thread via GitHub
yingcai-cy commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2099701159 ## src/iceberg/avro/avro_stream_internal.cc: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor licens

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-20 Thread via GitHub
wgtmac commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2099154550 ## src/iceberg/avro/avro_stream.cc: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-20 Thread via GitHub
wgtmac commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2097552424 ## src/iceberg/avro/avro_stream.cc: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-20 Thread via GitHub
zhjwpku commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2098036170 ## src/iceberg/avro/avro_stream.cc: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements

Re: [PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-20 Thread via GitHub
wgtmac commented on code in PR #105: URL: https://github.com/apache/iceberg-cpp/pull/105#discussion_r2097311477 ## src/iceberg/CMakeLists.txt: ## @@ -79,8 +79,12 @@ install(FILES ${CMAKE_CURRENT_BINARY_DIR}/iceberg_export.h DESTINATION ${ICEBERG_INSTALL_INCLUDEDIR}/iceb

[PR] feat: add avro input&output stream based on arrow stream impl [iceberg-cpp]

2025-05-20 Thread via GitHub
dongxiao1198 opened a new pull request, #105: URL: https://github.com/apache/iceberg-cpp/pull/105 support basic avro stream based on arrow implement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t