Re: [PR] feat: add apply in transaction to support stack action [iceberg-rust]

2025-03-12 Thread via GitHub
ZENOTME commented on code in PR #949: URL: https://github.com/apache/iceberg-rust/pull/949#discussion_r1990812405 ## crates/iceberg/src/transaction.rs: ## @@ -261,7 +286,7 @@ impl<'a> FastAppendAction<'a> { let mut manifest_stream = self .snapshot_p

Re: [PR] feat: add apply in transaction to support stack action [iceberg-rust]

2025-03-11 Thread via GitHub
ZENOTME commented on PR #949: URL: https://github.com/apache/iceberg-rust/pull/949#issuecomment-2713273786 I think this PR is ready to review. cc @Fokko @liurenjie1024 @Xuanwo @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] feat: add apply in transaction to support stack action [iceberg-rust]

2025-02-13 Thread via GitHub
ZENOTME commented on PR #949: URL: https://github.com/apache/iceberg-rust/pull/949#issuecomment-2655981130 Hi @liurenjie1024, I think we should resolve this PR first before working on #964. It will affect the interface in transactions. -- This is an automated message from the Apache

Re: [PR] feat: add apply in transaction to support stack action [iceberg-rust]

2025-02-07 Thread via GitHub
ZENOTME commented on PR #949: URL: https://github.com/apache/iceberg-rust/pull/949#issuecomment-2642680924 cc @Fokko @liurenjie1024 @Xuanwo @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t