Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-06-10 Thread via GitHub
liurenjie1024 merged PR #363: URL: https://github.com/apache/iceberg-rust/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-06-08 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1632091191 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -223,11 +217,10 @@ impl BoundPredicateVisitor for ExpressionEvaluatorVisitor<'_> {

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-06-08 Thread via GitHub
sdd commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1631990232 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -223,11 +217,10 @@ impl BoundPredicateVisitor for ExpressionEvaluatorVisitor<'_> { literal:

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-06-07 Thread via GitHub
marvinlanhenke commented on PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#issuecomment-2154570466 @liurenjie1024 @sdd I changed the impl to reflect the changes made in #390 PTAL. Thanks again @sdd for unblocking this PR. -- This is an automated message from the Apache

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-06-01 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1623218410 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-24 Thread via GitHub
sdd commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1613965281 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-23 Thread via GitHub
liurenjie1024 commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1612791416 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-23 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1612174468 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-23 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1612178234 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-23 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1612174468 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-23 Thread via GitHub
liurenjie1024 commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1611740946 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-23 Thread via GitHub
liurenjie1024 commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1611740946 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-23 Thread via GitHub
liurenjie1024 commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1611733596 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-22 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1610308227 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-22 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1610308227 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-22 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1610294455 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-22 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1610294455 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-22 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1610284297 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-22 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1610241256 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-22 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1610241256 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-22 Thread via GitHub
liurenjie1024 commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1610110676 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-04 Thread via GitHub
sdd commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1590223772 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-03 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1589299148 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-03 Thread via GitHub
sdd commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1588936688 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-03 Thread via GitHub
sdd commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1588936688 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-03 Thread via GitHub
sdd commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1588925183 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-02 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1588191095 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -260,30 +260,6 @@ mod test { Ok((Arc::new(schema), Arc::new(spec))) } -fn