Re: [PR] feat: TableMetadata Statistic Files [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo merged PR #799: URL: https://github.com/apache/iceberg-rust/pull/799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] feat: TableMetadata Statistic Files [iceberg-rust]

2024-12-16 Thread via GitHub
c-thiel commented on code in PR #799: URL: https://github.com/apache/iceberg-rust/pull/799#discussion_r1886956770 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -524,6 +526,52 @@ impl TableMetadataBuilder { self } +/// Set statistics for a snapsh

Re: [PR] feat: TableMetadata Statistic Files [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #799: URL: https://github.com/apache/iceberg-rust/pull/799#discussion_r1886823887 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -524,6 +526,52 @@ impl TableMetadataBuilder { self } +/// Set statistics for a snapshot

Re: [PR] feat: TableMetadata Statistic Files [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #799: URL: https://github.com/apache/iceberg-rust/pull/799#discussion_r1886819635 ## crates/iceberg/src/catalog/mod.rs: ## @@ -446,6 +446,30 @@ pub enum TableUpdate { /// Properties to remove removals: Vec, }, +/// Set sta

Re: [PR] feat: TableMetadata Statistic Files [iceberg-rust]

2024-12-13 Thread via GitHub
c-thiel commented on code in PR #799: URL: https://github.com/apache/iceberg-rust/pull/799#discussion_r1884798642 ## crates/iceberg/src/spec/table_metadata.rs: ## @@ -158,11 +160,15 @@ pub struct TableMetadata { /// writers, but is not used when reading because reads use th

Re: [PR] feat: TableMetadata Statistic Files [iceberg-rust]

2024-12-13 Thread via GitHub
c-thiel commented on code in PR #799: URL: https://github.com/apache/iceberg-rust/pull/799#discussion_r1884298259 ## crates/iceberg/src/catalog/mod.rs: ## @@ -446,6 +446,30 @@ pub enum TableUpdate { /// Properties to remove removals: Vec, }, +/// Set s