liurenjie1024 commented on PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#issuecomment-2568880240
> Let's get #863 merge first.
+1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Xuanwo commented on PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#issuecomment-2567770392
Let's get https://github.com/apache/iceberg-rust/pull/863 merge first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1900849628
##
crates/iceberg/src/table.rs:
##
@@ -203,7 +203,7 @@ impl Table {
/// Creates a metadata table which provides table-like APIs for inspecting
metadata.
/
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1900849080
##
crates/iceberg/src/lib.rs:
##
@@ -73,7 +73,7 @@ mod avro;
pub mod io;
pub mod spec;
-pub mod metadata_scan;
+pub mod metadata_table;
Review Comment:
Follow-
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1900846008
##
crates/iceberg/src/metadata_table.rs:
##
@@ -451,7 +540,7 @@ mod tests {
partition_summaries: ListArray
[
Struc
rshkv commented on PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#issuecomment-2565741489
Thank you, @xuanwo. This is rebased and ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Xuanwo commented on PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#issuecomment-2565637928
https://github.com/apache/iceberg-rust/pull/822 has been merged, let's move
on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1897375800
##
crates/iceberg/src/scan.rs:
##
@@ -1019,7 +1022,7 @@ mod tests {
.metadata(table_metadata)
.identifier(TableIdent::from_strs(["db"
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1897375353
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1897371026
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1897369513
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
rshkv opened a new pull request, #846:
URL: https://github.com/apache/iceberg-rust/pull/846
Re #823. This adds support for the [Metadata Log Entries][Java] metadata
table.
This is building on @xxchan's unmerged #822. I'll update and rebase this PR
when #822 merges.
Metadata Lo
12 matches
Mail list logo
