Re: [PR] feat: SQL Catalog - Tables [iceberg-rust]

2024-10-12 Thread via GitHub
liurenjie1024 merged PR #610: URL: https://github.com/apache/iceberg-rust/pull/610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: SQL Catalog - Tables [iceberg-rust]

2024-09-28 Thread via GitHub
liurenjie1024 commented on code in PR #610: URL: https://github.com/apache/iceberg-rust/pull/610#discussion_r1779838127 ## crates/catalog/sql/src/catalog.rs: ## @@ -472,36 +479,287 @@ impl Catalog for SqlCatalog { } } -async fn drop_namespace(&self, _namespac

Re: [PR] feat: SQL Catalog - Tables [iceberg-rust]

2024-09-16 Thread via GitHub
callum-ryan commented on code in PR #610: URL: https://github.com/apache/iceberg-rust/pull/610#discussion_r1761619195 ## crates/catalog/sql/src/error.rs: ## @@ -32,3 +32,20 @@ pub fn no_such_namespace_err(namespace: &NamespaceIdent) -> Result { format!("No such namespa

Re: [PR] feat: SQL Catalog - Tables [iceberg-rust]

2024-09-13 Thread via GitHub
kevinjqliu commented on code in PR #610: URL: https://github.com/apache/iceberg-rust/pull/610#discussion_r1759659001 ## crates/catalog/sql/src/error.rs: ## @@ -32,3 +32,20 @@ pub fn no_such_namespace_err(namespace: &NamespaceIdent) -> Result { format!("No such namespac

[PR] feat: SQL Catalog - Tables [iceberg-rust]

2024-09-07 Thread via GitHub
callum-ryan opened a new pull request, #610: URL: https://github.com/apache/iceberg-rust/pull/610 this is a WIP. Pulling tests in from @fqaiser94's original recommended test set as I go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on