liurenjie1024 merged PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#issuecomment-1990023145
> Let's say that you have a table with number: i32 column. At some point,
you'll evolve this column to number: i64. New data will be written as a long,
but the old data will stil
Fokko commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1520407376
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -172,6 +223,146 @@ pub enum Predicate {
Set(SetExpression),
}
+impl Bind for Predicate {
+type Bound = Bound
sdd commented on PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#issuecomment-1987797610
> I took a look at python's code again and realised that we should not
couple not rewrite with binding, since not rewrite is not as widely used as
binding, and we still need a rewriter. cc
Xuanwo commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1519137105
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -55,6 +60,24 @@ impl LogicalExpression {
}
}
+impl Bind for LogicalExpression
+where
+T::Bound: Sized,
+{
+
liurenjie1024 commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1519136619
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -55,6 +60,24 @@ impl LogicalExpression {
}
}
+impl Bind for LogicalExpression
+where
+T::Bound: Size
Xuanwo commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1519133419
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -406,13 +635,239 @@ mod tests {
#[test]
fn test_predicate_negate_set() {
-let expression =
Referen
Xuanwo commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1519132180
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -55,6 +60,24 @@ impl LogicalExpression {
}
}
+impl Bind for LogicalExpression
+where
+T::Bound: Sized,
+{
+
liurenjie1024 commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1519131858
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -406,13 +635,239 @@ mod tests {
#[test]
fn test_predicate_negate_set() {
-let expression =
liurenjie1024 commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1519131277
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -55,6 +60,24 @@ impl LogicalExpression {
}
}
+impl Bind for LogicalExpression
+where
+T::Bound: Size
Xuanwo commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1519129192
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -406,13 +635,239 @@ mod tests {
#[test]
fn test_predicate_negate_set() {
-let expression =
Referen
liurenjie1024 commented on PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#issuecomment-1987569345
I took a look at python's code again and realized that we should not couple
not rewrite with binding, since not rewrite is not as widely used as binding,
and we still need a rewr
liurenjie1024 commented on PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#issuecomment-1986848432
> Changes from review look good to me. Because we're now doing the
NOT-elimination here at bind time, does this mean that this PR effectively
completes #150 as well?
Seem
sdd commented on PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#issuecomment-1986847123
Changes from review look good to me. Because we're now doing the
NOT-elimination here at bind time, does this mean that this PR effectively
completes https://github.com/apache/iceberg-rust
liurenjie1024 commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1518562233
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -55,6 +60,29 @@ impl LogicalExpression {
}
}
+impl Bind for LogicalExpression {
+type Bound = Logica
sdd commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1517243146
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -406,13 +640,239 @@ mod tests {
#[test]
fn test_predicate_negate_set() {
-let expression =
Reference:
sdd commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1517231867
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -172,6 +228,146 @@ pub enum Predicate {
Set(SetExpression),
}
+impl Bind for Predicate {
+type Bound = BoundPr
sdd commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1517228198
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -55,6 +60,29 @@ impl LogicalExpression {
}
}
+impl Bind for LogicalExpression {
+type Bound = LogicalExpressio
sdd commented on code in PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#discussion_r1517227108
##
crates/iceberg/src/expr/mod.rs:
##
@@ -147,6 +149,14 @@ impl PredicateOperator {
}
}
+/// Bind expression to a schema.
+pub trait Bind {
+/// The type of
liurenjie1024 commented on PR #231:
URL: https://github.com/apache/iceberg-rust/pull/231#issuecomment-1983016798
This pr is ready for review. cc @Fokko @Xuanwo @sdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
liurenjie1024 opened a new pull request, #231:
URL: https://github.com/apache/iceberg-rust/pull/231
Close #149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
21 matches
Mail list logo
