Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-11 Thread via GitHub
liurenjie1024 commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1836567657 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,8 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-11 Thread via GitHub
liurenjie1024 merged PR #689: URL: https://github.com/apache/iceberg-rust/pull/689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-11 Thread via GitHub
liurenjie1024 commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1836565995 ## crates/iceberg/src/catalog/mod.rs: ## @@ -453,6 +453,115 @@ impl TableUpdate { } } +impl TableRequirement { +/// Check that the requirement is m

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-08 Thread via GitHub
c-thiel commented on PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#issuecomment-2465147688 @liurenjie1024 ready for another round! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-08 Thread via GitHub
c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834645951 ## crates/iceberg/src/catalog/mod.rs: ## @@ -453,6 +453,115 @@ impl TableUpdate { } } +impl TableRequirement { +/// Check that the requirement is met by

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-08 Thread via GitHub
c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834644947 ## crates/iceberg/src/catalog/mod.rs: ## @@ -453,6 +453,115 @@ impl TableUpdate { } } +impl TableRequirement { +/// Check that the requirement is met by

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-08 Thread via GitHub
c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834645491 ## crates/iceberg/src/catalog/mod.rs: ## @@ -453,6 +453,115 @@ impl TableUpdate { } } +impl TableRequirement { +/// Check that the requirement is met by

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-08 Thread via GitHub
c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834631345 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,8 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-08 Thread via GitHub
c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834629086 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,8 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-08 Thread via GitHub
c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834624350 ## crates/iceberg/src/catalog/mod.rs: ## @@ -453,6 +453,115 @@ impl TableUpdate { } } +impl TableRequirement { +/// Check that the requirement is met by

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-08 Thread via GitHub
liurenjie1024 commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834381560 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,8 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

2024-11-06 Thread via GitHub
c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1832067510 ## crates/iceberg/src/catalog/mod.rs: ## @@ -312,29 +312,29 @@ pub enum TableRequirement { LastAssignedFieldIdMatch { /// The last assigned field id of