subject:"\[PR\] feat\: Implement Iceberg values \[iceberg\-rust\]"

Re: [PR] feat: Implement Iceberg values [iceberg-rust]

2023-10-17 Thread via GitHub

JanKaul commented on code in PR #20: URL: https://github.com/apache/iceberg-rust/pull/20#discussion_r1361677800 ## crates/iceberg/src/spec/values.rs: ## @@ -0,0 +1,964 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] feat: Implement Iceberg values [iceberg-rust]

2023-10-17 Thread via GitHub

JanKaul commented on code in PR #20: URL: https://github.com/apache/iceberg-rust/pull/20#discussion_r1361668958 ## crates/iceberg/src/spec/values.rs: ## @@ -0,0 +1,964 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] feat: Implement Iceberg values [iceberg-rust]

2023-10-16 Thread via GitHub

ZENOTME commented on code in PR #20: URL: https://github.com/apache/iceberg-rust/pull/20#discussion_r1360827510 ## crates/iceberg/src/spec/values.rs: ## @@ -0,0 +1,964 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] feat: Implement Iceberg values [iceberg-rust]

2023-10-16 Thread via GitHub

ZENOTME commented on code in PR #20: URL: https://github.com/apache/iceberg-rust/pull/20#discussion_r1360827510 ## crates/iceberg/src/spec/values.rs: ## @@ -0,0 +1,964 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.