Fokko merged PR #174:
URL: https://github.com/apache/iceberg-rust/pull/174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Xuanwo commented on PR #174:
URL: https://github.com/apache/iceberg-rust/pull/174#issuecomment-1925703005
cc @liurenjie1024, please review again. Sorry for the late.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Xuanwo commented on code in PR #174:
URL: https://github.com/apache/iceberg-rust/pull/174#discussion_r1477279307
##
crates/catalog/hms/src/catalog.rs:
##
@@ -71,19 +54,29 @@ impl Debug for HmsCatalog {
impl HmsCatalog {
/// Create a new hms catalog.
pub fn new(config:
Xuanwo commented on code in PR #174:
URL: https://github.com/apache/iceberg-rust/pull/174#discussion_r1477279307
##
crates/catalog/hms/src/catalog.rs:
##
@@ -71,19 +54,29 @@ impl Debug for HmsCatalog {
impl HmsCatalog {
/// Create a new hms catalog.
pub fn new(config:
Xuanwo commented on code in PR #174:
URL: https://github.com/apache/iceberg-rust/pull/174#discussion_r1477279054
##
crates/catalog/hms/src/utils.rs:
##
@@ -15,13 +15,28 @@
// specific language governing permissions and limitations
// under the License.
+use anyhow::anyhow;
Xuanwo commented on code in PR #174:
URL: https://github.com/apache/iceberg-rust/pull/174#discussion_r1477278925
##
crates/catalog/hms/Cargo.toml:
##
@@ -28,13 +28,9 @@ license = { workspace = true }
keywords = ["iceberg", "hive", "catalog"]
[dependencies]
+anyhow = { worksp
liurenjie1024 commented on PR #174:
URL: https://github.com/apache/iceberg-rust/pull/174#issuecomment-1920810766
cc @Xuanwo Any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
liurenjie1024 commented on code in PR #174:
URL: https://github.com/apache/iceberg-rust/pull/174#discussion_r1468272268
##
crates/catalog/hms/src/catalog.rs:
##
@@ -71,19 +54,29 @@ impl Debug for HmsCatalog {
impl HmsCatalog {
/// Create a new hms catalog.
pub fn new(
