Re: [PR] feat: Allow for schema evolution [iceberg-rust]

2024-12-13 Thread via GitHub
Xuanwo merged PR #786: URL: https://github.com/apache/iceberg-rust/pull/786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] feat: Allow for schema evolution [iceberg-rust]

2024-12-13 Thread via GitHub
Xuanwo commented on PR #786: URL: https://github.com/apache/iceberg-rust/pull/786#issuecomment-2540873200 Thank you for the explanation! This PR is good enough for me. Let's proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] feat: Allow for schema evolution [iceberg-rust]

2024-12-13 Thread via GitHub
Fokko commented on PR #786: URL: https://github.com/apache/iceberg-rust/pull/786#issuecomment-2540869512 This is pretty similar. With this PR we first write an int, and then read it as a long, which is a valid schema evolution. In the case of #790 we try to read a narrower decimal from the

Re: [PR] feat: Allow for schema evolution [iceberg-rust]

2024-12-13 Thread via GitHub
Xuanwo commented on PR #786: URL: https://github.com/apache/iceberg-rust/pull/786#issuecomment-2540855953 Hi @Fokko, I'm following up on issue #790. It appears this PR doesn't address the scenario I described in #790, where the underlying parquet schema differs from the declared one.