Re: [PR] feat: Add deletion vector related fields in spec types [iceberg-rust]

2025-04-30 Thread via GitHub
liurenjie1024 merged PR #1276: URL: https://github.com/apache/iceberg-rust/pull/1276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] feat: Add deletion vector related fields in spec types [iceberg-rust]

2025-04-30 Thread via GitHub
dentiny commented on code in PR #1276: URL: https://github.com/apache/iceberg-rust/pull/1276#discussion_r2069092795 ## crates/iceberg/src/spec/manifest/data_file.rs: ## @@ -151,6 +151,26 @@ pub struct DataFile { /// This field is not included in spec. It is just store in me

Re: [PR] feat: Add deletion vector related fields in spec types [iceberg-rust]

2025-04-29 Thread via GitHub
Xuanwo commented on PR #1276: URL: https://github.com/apache/iceberg-rust/pull/1276#issuecomment-2840992046 Hi @dentiny, I have updated the PR title to better reflect the changes. I have to say that I completely agree with your "upstream first" philosophy, and I appreciate any kind of help.