Re: [PR] feat: Add basic conflict detection [iceberg-rust]

2025-04-02 Thread via GitHub
jonathanc-n commented on PR #1154: URL: https://github.com/apache/iceberg-rust/pull/1154#issuecomment-2773774727 @Fokko @ZENOTME Yeah will change title, I just wanted to open this to discuss what our plan was for the conflict detection. -- This is an automated message from the Apache Git

Re: [PR] feat: Add basic conflict detection [iceberg-rust]

2025-04-02 Thread via GitHub
ZENOTME commented on code in PR #1154: URL: https://github.com/apache/iceberg-rust/pull/1154#discussion_r2024859346 ## crates/iceberg/src/transaction/mod.rs: ## @@ -127,12 +127,14 @@ impl<'a> Transaction<'a> { } /// Creates a fast append action. -pub fn fast_appe

Re: [PR] feat: Add basic conflict detection [iceberg-rust]

2025-04-02 Thread via GitHub
Fokko commented on PR #1154: URL: https://github.com/apache/iceberg-rust/pull/1154#issuecomment-2772487148 @jonathanc-n This is the very first step, and we indeed want this. I don't think this is the actual conflict detection. When between the `fast_append()` and `commit()` something

[PR] feat: Add basic conflict detection [iceberg-rust]

2025-04-01 Thread via GitHub
jonathanc-n opened a new pull request, #1154: URL: https://github.com/apache/iceberg-rust/pull/1154 ## Which issue does this PR close? - Mentioned [here](https://github.com/apache/iceberg-rust/issues/964) ## What changes are included in this PR? Added basic confli

Re: [PR] feat: Add basic conflict detection [iceberg-rust]

2025-04-01 Thread via GitHub
jonathanc-n commented on PR #1154: URL: https://github.com/apache/iceberg-rust/pull/1154#issuecomment-2771198141 Is this on track with what we want? cc @liurenjie1024 @Fokko @ZENOTME -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G